Ard Biesheuvel <ard.biesheu...@linaro.org> wrote:
> > Looking in efi_get_secureboot(), is there a reason:
> >
> > efi_guid_t var_guid = EFI_GLOBAL_VARIABLE_GUID;
> >
> > isn't static const?
> >
>
> Not a good one, no. It used to be static const, but for some reason,
> commit 30d7bf034c03 ("efi/arm64: Check SetupMode when determining
> Secure Boot status") removed the static and the const (and I reviewed
> it and did not complain AFAIR)
> I'll gladly take a patch that reinstates that, though.
Also, is there a reason that:
typedef efi_status_t efi_get_variable_t (efi_char16_t *name, efi_guid_t
*vendor, u32 *attr,
unsigned long *data_size, void *data);
Doesn't have const name and vendor?
David
