Lukas Wunner <[email protected]> wrote: > On Tue, Nov 22, 2016 at 02:47:27PM +0000, David Howells wrote: > > Lukas Wunner <[email protected]> wrote: > > > The "out_efi_err" portion differs from the previous version of this > > > patch. Setting a __u8 to a negative value, is this really what you > > > want? > > > > Eh? efi_get_secureboot() returns an int as before. The out_efi_err: > > portions are exactly the same: > > By "the previous version of this patch" I was referring to your > submission of Nov 16, not the existing code in the kernel. > Your patch didn't contain the out_efi_err portion. > > You're assigning a negative value to boot_params->secure_boot > (which is declared __u8).
Ah, yes. Sorry, you confused me by specifying a comparison against the last version. David
