Hello, The current TWL MFD driver has a number of problems which are very well described by Russell King [0]. This series attemps to fix this by making the driver's private structure available to child nodes. A regulator driver for TWL6032 which makes use of the private drvdata is introduced. A driver for TWL6032 PMIC already exists in mainline, twl-regulator, but it has the following drawbacks: * has no mainline users * it does not follow the recommended regulators binding since it uses a compatible string for every regulator; * it is broken ** the features flag is not set, hence the TWL6032 support is broken since it depends on TWL6032_SUBCLASS flag; ** even with that fixed, bit manipulations are wrong
If this receives positive feedback, I could convert all TWL drivers to use drvdata, then get rid of the exported symbols. [0] https://www.spinics.net/lists/linux-omap/msg133387.html Nicolae Rosia (5): mfd: twl-core: make driver DT only mfd: twl: remove useless header mfd: twl: move structure definitions to a public header regulator: Add support for TI TWL6032 mfd: twl: use mfd_add_devices for TWL6032 regulator .../bindings/regulator/twl6032-regulator.txt | 109 ++++ drivers/mfd/Kconfig | 1 + drivers/mfd/twl-core.c | 444 ++-------------- drivers/mfd/twl-core.h | 10 - drivers/mfd/twl4030-irq.c | 2 - drivers/mfd/twl6030-irq.c | 2 - drivers/regulator/Kconfig | 7 + drivers/regulator/Makefile | 1 + drivers/regulator/twl6032-regulator.c | 582 +++++++++++++++++++++ include/linux/mfd/twl-core.h | 35 ++ 10 files changed, 768 insertions(+), 425 deletions(-) create mode 100644 Documentation/devicetree/bindings/regulator/twl6032-regulator.txt delete mode 100644 drivers/mfd/twl-core.h create mode 100644 drivers/regulator/twl6032-regulator.c create mode 100644 include/linux/mfd/twl-core.h -- 2.9.3
