BNX2FC_NUM_ERR_BITS is 63. err_warn_bit_map is a u64. So, to make sure that no shift wrapping will occur, we need need additionnal casting.
The same test is already done a few lines above and '(u64)1' is already used there. So just do the same here. Signed-off-by: Christophe JAILLET <[email protected]> --- I guess that this could also be written with a '1ULL << i' which would be cleaner and less verbose IMHO, but apparently this driver does not use such things yet. So keep the current style with casting. --- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c index 5ff9f89c17c7..a9dccb3b49cc 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c @@ -829,7 +829,7 @@ static void bnx2fc_process_unsol_compl(struct bnx2fc_rport *tgt, u16 wqe) ((u64)err_entry->data.err_warn_bitmap_hi << 32) | (u64)err_entry->data.err_warn_bitmap_lo; for (i = 0; i < BNX2FC_NUM_ERR_BITS; i++) { - if (err_warn_bit_map & (u64) (1 << i)) { + if (err_warn_bit_map & (u64)((u64)1 << i)) { err_warn = i; break; } -- 2.9.3
