On 11/24, Viresh Kumar wrote:
> Later patches would add support for custom opp_set_rate callbacks. This
> patch separates out the code for generic opp_set_rate handler in order
> to prepare for that.

s/opp_set_rate/set_opp/ twice?

> 
> Signed-off-by: Viresh Kumar <[email protected]>
> Tested-by: Dave Gerlach <[email protected]>
> ---

Besides the naming confusion.

Reviewed-by: Stephen Boyd <[email protected]>

> @@ -1422,6 +1488,11 @@ int dev_pm_opp_set_regulators(struct device *dev, 
> const char * const names[],
>  
>       opp_table->regulator_count = count;
>  
> +     /* Allocate block only once to pass to ->set_rate() */

_generic_set_opp()? Or just set_opp when that gets introduced in
the next patch.

> +     ret = _allocate_set_opp_data(opp_table);
> +     if (ret)
> +             goto free_regulators;
> +
>       mutex_unlock(&opp_table_lock);
>       return 0;
>  

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Reply via email to