On Mon, 2007-03-05 at 14:57 -0800, Andrew Morton wrote: > Is OK, I think. nobh_prepare_write() brings the outside-from-and-to > sections of the page uptodate and memset in nobh_truncate_page() brings the > rest of the page uptodate. > > We bring the to->PAGE_CACHE_SIZE section uptodate twice, which could be > optimised.
Why not have nobh_truncate_page() call prepare_write() with to = PAGE_CACHE_SIZE? I don't really grok: to = (offset + blocksize) & ~(blocksize - 1); -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/