On Sun, Dec 04, 2016 at 12:51:53PM +0800, Pan Bian wrote: > In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret > on errors. However, it directly returns 0. It may be better to return > ret. This patch also removes the warning, because the caller already > prints a warning. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731
Looks good. Reviewed-by: Omar Sandoval <osan...@fb.com> > Signed-off-by: Pan Bian <bianpan2...@163.com> > --- > fs/btrfs/uuid-tree.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/btrfs/uuid-tree.c b/fs/btrfs/uuid-tree.c > index 7fc89e4..83bb2f2 100644 > --- a/fs/btrfs/uuid-tree.c > +++ b/fs/btrfs/uuid-tree.c > @@ -351,7 +351,5 @@ int btrfs_uuid_tree_iterate(struct btrfs_fs_info *fs_info, > > out: > btrfs_free_path(path); > - if (ret) > - btrfs_warn(fs_info, "btrfs_uuid_tree_iterate failed %d", ret); > - return 0; > + return ret; > } > -- > 1.9.1 > >
