On Mon, 5 Dec 2016, Matt Redfearn wrote: > Ah yes, I missed the .set reorder above the EVA ifdef and just included the > .set reorder as the similar snippet here: > http://lxr.free-electrons.com/source/arch/mips/include/asm/stackframe.h#L149
That's a global `.set reorder' for the whole of SAVE_SOME, just as I suggested for all the macros here. Then a temporary `.set noreorder' override follows just for the manually scheduled BLTZ/MOVE sequence, where someone has later inserted a whole CONFIG_EVA block. As I noted this temporary override is unnecessary. Incidentally it does not harm the CONFIG_EVA block either, because EVA processors have MFC0 interlocked. NB I think the MFC0 macro ought to be called REG_MFC0, to avoid confusion and for consistency with the rest of such macros. Maciej
