Hi Pavel, On 05.12.2016 23:02, Pavel Machek wrote: > > we need spin_lock_bh at minimum, as we are locking user context > against timer. > > Best regards, > Pavel >
I was referring to stmmac_tx_clean() which AFAICS is only called from softirq context, (one time in the timer handler and one time in napi poll handler) so a spin_lock() should be sufficient. I cant see how this is called from userspace. If it were, a spin_lock_bh() had to be used, of course. Regards, Lino
