On Tue, Dec 06, 2016 at 12:10:50PM -0800, Kees Cook wrote: > On Tue, Dec 6, 2016 at 10:18 AM, Mark Rutland <[email protected]> wrote: > > On Tue, Nov 29, 2016 at 11:39:44AM -0800, Kees Cook wrote: > >> On Tue, Nov 29, 2016 at 10:55 AM, Laura Abbott <[email protected]> wrote: > >> > > >> > The usercopy checking code currently calls __va(__pa(...)) to check for > >> > aliases on symbols. Switch to using lm_alias instead. > >> > > >> > Signed-off-by: Laura Abbott <[email protected]> > >> > >> Acked-by: Kees Cook <[email protected]> > >> > >> I should probably add a corresponding alias test to lkdtm... > >> > >> -Kees > > > > Something like the below? > > > > It uses lm_alias(), so it depends on Laura's patches. We seem to do the > > right thing, anyhow: > > Cool, this looks good. What happens on systems without an alias?
In that case, lm_alias() should be an identity function, and we'll just hit the usual kernel address (i.e. it should be identical to USERCOPY_KERNEL). > Laura, feel free to add this to your series: > > Acked-by: Kees Cook <[email protected]> I'm happy with that, or I can resend this as a proper patch once the rest is in. Thanks, Mark.
