> Actually, the original code worked fine,

I got my doubts when some memory allocations are attempted without checking
the desired success immediately.


> and these changes will result in an Oops if the allocations fail.  I'll 
> explain why,
> since it isn't obvious without some knowledge of the clean-up strategy used 
> by comedi drivers:

Thanks for your explanation.


> …, and all the other comedi drivers follow the same strategy of leaving 
> clean-up
> to their comedi 'detach' handler.

Are there other source code parts worth for further considerations?

Regards,
Markus

Reply via email to