> From c4a21c2ac0c587094000a3daeb13eec6056dc63f Mon Sep 17 00:00:00 2001 > From: Max <jbi...@google.com> > Date: Fri, 9 Dec 2016 15:16:47 -0800 > Subject: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on > > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller kernel, attack surface reduction) if it's not being used. Adding > a message here in order to make this user visible. > > Signed-off-by: Max Bires <jbi...@google.com>
This patch seems reasonable to me. > drivers/char/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index 7ad3127..70e626c 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -589,10 +589,13 @@ config TELCLOCK > controlling the behavior of this hardware. > > config DEVPORT > - bool > + bool "/dev/port character device" > depends on !M68K > depends on ISA || PCI > default y > + help > + Say Y here if you want to support the /dev/port device. The > + /dev/port device is similar to /dev/mem, but for I/O ports. > > config DCC_TTY > tristate "DCC tty driver" > -- > 2.8.0.rc3.226.g39d4020