On 16.12.2016 16:37, David Gstir wrote: >> @@ -349,33 +347,10 @@ int fscrypt_zeroout_range(const struct inode *inode, >> pgoff_t lblk, >> err = do_page_crypto(inode, FS_ENCRYPT, lblk, >> ZERO_PAGE(0), ciphertext_page, >> PAGE_SIZE, 0, GFP_NOFS); >> + err = fscrypt_bio_submit_page(inode, pblk, ciphertext_page); > > Any specific reason why you didn't just move the whole > fscrypt_zeroout_range() to bio.c?
The function depends other internal functions of crypto.c which I didn't want to export. At the end of the day it's a matter of taste. I found it less ugly to keep fscrypt_zeroout_range() in crypto.c than exposing internal stuff. Thanks, //richard
