Hi Arnaldo, Here is a patch which checks that objdump works without calling it first with the "-v" option.
Thanks to the shell pipefail option (which returns the rightmost error status in the shell pipe) and the grep subshell which prevents "no-match" errors, we are able the use waitpid on the whole pipeline and get the appropriate return code. This is the most simple and straightforward solution I found. The downside might be that it relies on the availability of "pipefail" shell option. However, I checked that even busybox's shell implemented it. Alexis. Alexis Berlemont (1): perf annotate: check that objdump correctly works tools/perf/util/annotate.c | 69 +++++++++++++++++++++++++++++++++++++++++++--- tools/perf/util/annotate.h | 3 ++ 2 files changed, 68 insertions(+), 4 deletions(-) -- 2.11.0
