Sergei Shtylyov writes: > I've floowed up to my patch with such explanation. In the context of > an-rt > patch itself, it was just too clear, hence I didn't go into explanations in > the patch itself. :-)
Well, it might be clear, to you, now, with the context in your head. But if such a patch is to go into a git tree, and somebody comes along in 3 years time and wants to know exactly why you made that change (and maybe that somebody is you :), then they will need more detail - such as how you came to the conclusion that those locks and no others needed to be changed, for instance. At least give some of the reasoning behind your choice of which locks to convert, so that in future, if the patch turns out to have introduced a bug somehow, the person debugging it can either identify that there was a flaw in your logic, or else understand something that you have seen that they missed. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
