On Thu, 2016-12-22 at 17:09 +0530, Arvind Yadav wrote: > Here, If pcim_iomap_table will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > This error check will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav <[email protected]> > --- > drivers/i2c/busses/i2c-designware-pcidrv.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c > b/drivers/i2c/busses/i2c-designware-pcidrv.c > index d6423cf..6a1907d 100644 > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c > @@ -235,6 +235,10 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, > dev->controller = controller; > dev->get_clk_rate_khz = i2c_dw_get_clk_rate_khz; > dev->base = pcim_iomap_table(pdev)[0]; > + if (!dev->base) { > + dev_err(&pdev->dev, "I/O map table allocation > failed\n"); > + return -ENOMEM; > + }
NAK. -- Andy Shevchenko <[email protected]> Intel Finland Oy
