Hi, Baolin Wang <[email protected]> writes: > Hi, > > On 27 December 2016 at 18:52, Janusz Dziedzic <[email protected]> > wrote: >> 2016-12-26 9:01 GMT+01:00 Baolin Wang <[email protected]>: >>> On some platfroms(like x86 platform), when one core is running the USB >>> gadget >>> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also >>> can >>> respond other interrupts from dwc3 controller and modify the event buffer by >>> dwc3_interrupt() function, that will cause getting the wrong event count in >>> irq thread handler to make the USB function abnormal. >>> >>> We should add spin_lock/unlock() in dwc3_check_event_buf() to avoid this >>> race. >>> >> Interesting, I always think we mask interrupt in dwc3_interrupt() by setting >> DWC3_GEVNTSIZ_INTMASK >> And unmask interrupt when we end dwc3_thread_interrupt(). >> >> So, we shouldn't get any IRQ from HW during dwc3_thread_interrupt(), >> or I miss something? >> Do you have some traces that indicate this masking will not work correctly? > > Yes, but we just masked the interrupts described in DEVTEN register, > and we did not mask all the interrupts, like the endpoint command > complete event, transfer complete event and so on, so we can still get > interrupts.
not true, we masked interrupts for the entire event buffer:
> static irqreturn_t dwc3_check_event_buf(struct dwc3_event_buffer *evt)
> {
> struct dwc3 *dwc = evt->dwc;
> u32 count;
> u32 reg;
>
> if (pm_runtime_suspended(dwc->dev)) {
> pm_runtime_get(dwc->dev);
> disable_irq_nosync(dwc->irq_gadget);
> dwc->pending_events = true;
> return IRQ_HANDLED;
> }
>
> count = dwc3_readl(dwc->regs, DWC3_GEVNTCOUNT(0));
> count &= DWC3_GEVNTCOUNT_MASK;
> if (!count)
> return IRQ_NONE;
>
> evt->count = count;
> evt->flags |= DWC3_EVENT_PENDING;
>
> /* Mask interrupt */
> reg = dwc3_readl(dwc->regs, DWC3_GEVNTSIZ(0));
> reg |= DWC3_GEVNTSIZ_INTMASK;
See here ?!?
> dwc3_writel(dwc->regs, DWC3_GEVNTSIZ(0), reg);
>
> return IRQ_WAKE_THREAD;
> }
>> BTW, what value you get when problem occured, 0xFFFC?
>
> Yes, something like this, the event count become huge.
please send us tracepoint data. You probably need to compress
it. Something like 256k of trace data is probably enough, so:
# mkdir -p /t
# mount -t tracefs none /t
# cd /t
# echo 256 > buffer_size_kb
# echo 1 > events/dwc3/enable
# echo 0 > events/dwc3/dwc3_readl/enable
# echo 0 > events/dwc3/dwc3_writel/enable
(reproduce)
# cp /t/trace /path/to/non-volatile/media/trace.txt
--
balbi
signature.asc
Description: PGP signature
