On 12/27/2016 09:49 PM, Kweh, Hock Leong wrote: >> -----Original Message----- >> From: David Miller [mailto:[email protected]] >> Sent: Wednesday, December 28, 2016 12:34 AM >> To: Kweh, Hock Leong <[email protected]> >> Cc: [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; Ong, Boon Leong >> <[email protected]>; Voon, Weifeng <[email protected]>; >> [email protected]; [email protected]; [email protected] >> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and >> stmmac_dvr_probe >> >> From: "Kweh, Hock Leong" <[email protected]> >> Date: Tue, 27 Dec 2016 22:42:36 +0800 >> >>> From: "Kweh, Hock Leong" <[email protected]> >> >> You are not the author of this change, do not take credit for it. >> >> You have copied Florian's patch character by character, therefore >> he is the author. >> >> You also didn't CC: the netdev mailing list properly. > > Hi David & Florian, > > Just to clarify that I do not copy exactly from Florian. > I have changed it to have proper handling on mdio unregister > while netdev_register() failed as showed below: > > return 0; > > -error_mdio_register: > - unregister_netdev(ndev); > error_netdev_register: > + stmmac_mdio_unregister(ndev);
Although this is required, we can't be doing it in all circumstances, we need to mimic what stmmac_drv_remove() does. Let me submit an incremental fix which takes care of mdio bus unregistration. -- Florian
