Hi Linus, On Mon, Dec 26, 2016 at 09:18:55PM +0100, Linus Walleij wrote: > The GPIO charger is using a mix of the legacy GPIO interface > and <linux/of_gpio.h> which is not the modern way to use GPIOs. > > Refactor like this: > > - Use a GPIO descriptor for the GPIO line used to monitor the > charger. > - Fetch the descriptor with devm_gpiod_get() as the first > method. > - If this fails and we are *not* using device tree, then > start looking to see if we can use platform data instead. > - After looking up and requesting a GPIO number with the > legacy API, convert it to a descriptor. > > This way we can later isolate and drop the legacy code as > more platforms move over to using descriptors. > > Cc: Dmitry Eremin-Solenikov <dbarysh...@gmail.com> > Cc: Heiko Stuebner <he...@sntech.de> > Cc: Lars-Peter Clausen <l...@metafoo.de> > Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
Thanks for your patch. I have queued it into power-supply's for-next branch: https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next -- Sebastian
signature.asc
Description: PGP signature
