On Wed, 04 Jan 2017, Florian Fainelli wrote: > Le 01/04/17 à 03:22, Lee Jones a écrit : > > On Wed, 28 Dec 2016, Florian Fainelli wrote: > > > >> This driver is currently only used to reboot the devices, but the > >> microcontroller hanging off UART1 on the Buffalo Kurobox Pro and > >> Terastation II Pro/Live is capable of a lot more than that, which we > >> will support in subsequent patches. For now, just add the reboot > >> functionality to make the kernel reboot correctly. > > > > This is not an MFD driver. You have written a UART driver. > > > > Please relocate it to drivers/char/tty/serial. > > Not that simple, and as explained in the cover letter the UART attached > micro controller can do a lot more than just reboot the machine, but
That's fine. This is precisely why we have MFD. But the core (MFD) driver should only conduct set-up of shared resources, registration of child devices and maybe some shared functionality required by >1 child device. All child device (i.e. UART) capability should be handled by the child drivers. > someone else is working on the driver, so this patch series can be ignored. Okay. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
