Hi Andy, Thanks for the review.
On Wed, 4 Jan 2017 15:14:10 +0200, Andy Shevchenko wrote: > On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <[email protected]> wrote: > > Dell-smbios is a helper module, it serves no purpose on its own, so > > do not present it as an option to the user. Instead, select it > > automatically whenever a driver which needs it is selected. > > > > Please, use prefix "platform/x86: ". > Perhaps, use just "dell_smbios: " as second one. OK, will change. > > config DELL_SMBIOS > > - tristate "Dell SMBIOS Support" > > - depends on DCDBAS > > + tristate > > + select DCDBAS > > > default n > > Do we need this one? Probably not. "n" being the default default, I guess the 844 occurrences of "default n" in the Kconfig tree are pointless ;-) I'll post v3 of the patch in a minute. -- Jean Delvare SUSE L3 Support
