On Thu, 5 Jan 2017 13:48:40 -0200 Thadeu Lima de Souza Cascardo <casca...@canonical.com> wrote:
> Ted T'so has added the function size_fifo in 1999 for the 2.3 series > [1], a long time ago. > > During the 2.5 cycle, Russell King has restructured the serial drivers > and, in that process, has suggested using schedule_timeout instead of > mdelay in size_fifo. [2] > > It was only at 2.6.7 that Greg Kroah-Hartman added the msleep function > to the core kernel, as people were starting to duplicate it. [3] > > However, as size_fifo is called under a spinlock from the autoconfig > function, we might not use msleep here, so removing that comment is the > appropriate thing to do. No.. it's still a flaw in the driver that we can't use msleep here. It's one of those things that people want to know if the probe locking ever gets restructured. Alan
