Hi! > When the console is in VT_AUTO/KD_GRAPHICS mode, switching to the > SUSPEND_CONSOLE fails, resulting in vt_waitactive() waiting indefinately > or until the task is interrupted. The following patch tests if a > console switch can occur in set_console() and returns early if a console > switch is not possible.
Your mailer wraps lines... How do I reproduce this? Suspending from X works for me...? > Signed-off-by: Andrew Johnson <[EMAIL PROTECTED]> > > diff -rup linux-2.6.20.1/drivers/char/vt.c linux/drivers/char/vt.c > --- linux-2.6.20.1/drivers/char/vt.c 2007-02-19 22:34:32.000000000 -0800 > +++ linux/drivers/char/vt.c 2007-03-08 14:15:41.000000000 -0800 > @@ -2188,10 +2188,20 @@ static void console_callback(struct work > release_console_sem(); > } > > -void set_console(int nr) > +extern char vt_dont_switch; > + > +int set_console(int nr) > { > + struct vc_data *vc = vc_cons[fg_console].d; > + > + if(!vc_cons_allocated(nr) || vt_dont_switch || vc->vc_mode == > KD_GRAPHICS) { > + return -EINVAL; > + } > + So... if current console is graphical, we leave X accessing the console... That's bad, because video state is not going to be restored...? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/