On Fri, 9 Mar 2007, Artem Bityutskiy wrote: > Randy Dunlap wrote: > > > it's clearly a configuration variable, but it's also being used by > > > itself in a few drivers/net/ source files. is that deliberate? > > > > The ones in drivers/net/ are just local driver debug controls. > > They happen to have the same name as a (likely newer) kconfig symbol. > > > > Is there a real problem that needs to be fixed? > > Renaming them just for the sake of being less confusing makes sense.
that's kind of what i had in mind. i have a script that peruses the source tree, checking for apparent typoes in preprocessor directives when someone forgets the leading "CONFIG_", and as long as that macro name is the way it is, that example is going to be flagged every time for no good reason. if someone wants to make a suggestion, i can submit a simple renaming patch. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
