On Fri 2007-03-09 23:34:00, Rafael J. Wysocki wrote: > On Friday, 9 March 2007 23:13, Pavel Machek wrote: > > Hi! > > > > > > > Index: linux-2.6.21-rc3/kernel/power/user.c > > > > > =================================================================== > > > > > --- linux-2.6.21-rc3.orig/kernel/power/user.c > > > > > +++ linux-2.6.21-rc3/kernel/power/user.c > > > > > @@ -402,9 +402,10 @@ static int snapshot_ioctl(struct inode * > > > > > > > > > > case PMOPS_ENTER: > > > > > if (data->platform_suspend) { > > > > > + disable_nonboot_cpus(); > > > > > > > > > > kernel_shutdown_prepare(SYSTEM_SUSPEND_DISK); > > > > > error = pm_ops->enter(PM_SUSPEND_DISK); > > > > > - error = 0; > > > > > + enable_nonboot_cpus(); > > > > > > > > Why did we discard return code in previous versions? Do we still want > > > > to do that? > > > > > > I think it was a mistake. > > > > I took a look at git-annotate, and it is yours code, so I assume you > > are right. ACK, then. > > Thanks! > > BTW, what about the patch at http://lkml.org/lkml/2007/3/8/363?
Seems obviously correct to me (ACK), but I did not have time to test it. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/