On Fri, Jan 13, 2017 at 10:34:06AM -0300, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense since this can't happen > in practice. The fact the probe function was called, means OF registered a > device with a valid compatible string so a of_device_get_match_data() call > will always succeed. So just remove this unneeded check. > > Signed-off-by: Javier Martinez Canillas <[email protected]> > Acked-by: Laxman Dewangan <[email protected]> > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 2/4. > - Mention in commit message that an unneeded check for match is removed. > > drivers/mfd/max77686.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-)
Reviewed-by: Krzysztof Kozlowski <[email protected]> Tested-by: Krzysztof Kozlowski <[email protected]> Best regards, Krzysztof
