On Fri, Jan 13, 2017 at 04:57:14PM +0100, Tobias Klauser wrote: > On 2017-01-13 at 10:52:49 +0100, Shyam Saini <mayhs11sa...@gmail.com> wrote: > > The region set by the call to memset, immediately overwritten by the > > subsequent call to memcpy and thus makes the memset redundant > > > > Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com> > > --- > > drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c > > b/drivers/net/ethernet/chelsio/cxgb4/sched.c > > index cbd68a8..5725693 100644 > > --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c > > +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c > > @@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct > > port_info *pi, > > struct ch_sched_params tp; > > > > memset(&info, 0, sizeof(info)); > > This memset is also redundant because info is memcpy()'ed to before > being used in the loop (and it isn't used outside of the loop). Thanks a lot for pointing out that.
I'll remove that too and resend it. Regards, Shyam
