[PATCH 1/2] platform/x86: fujitsu-laptop: decrease indentation in acpi_fujitsu_notify()

[Michał Kępień]

acpi_fujitsu_notify() is pretty deeply nested, which hurts readability.
Strip off one level of indentation by returning early when the event
code supplied as argument is not ACPI_FUJITSU_NOTIFY_CODE1.

Signed-off-by: Michał Kępień <ker...@kempniu.pl>
---
Changes introduced by this patch are best viewed when whitespace changes
are ignored.

 drivers/platform/x86/fujitsu-laptop.c | 64 ++++++++++++++++++-----------------
 1 file changed, 33 insertions(+), 31 deletions(-)

diff --git a/drivers/platform/x86/fujitsu-laptop.c 
b/drivers/platform/x86/fujitsu-laptop.c
index 96f8163d5002..35c1319b7c8e 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -789,40 +789,42 @@ static void acpi_fujitsu_notify(struct acpi_device 
*device, u32 event)
 
        input = fujitsu->input;
 
-       switch (event) {
-       case ACPI_FUJITSU_NOTIFY_CODE1:
-               keycode = 0;
-               oldb = fujitsu->brightness_level;
-               get_lcd_level();
-               newb = fujitsu->brightness_level;
-
-               vdbg_printk(FUJLAPTOP_DBG_TRACE,
-                           "brightness button event [%i -> %i (%i)]\n",
-                           oldb, newb, fujitsu->brightness_changed);
-
-               if (oldb < newb) {
-                       if (disable_brightness_adjust != 1) {
-                               if (use_alt_lcd_levels)
-                                       set_lcd_level_alt(newb);
-                               else
-                                       set_lcd_level(newb);
-                       }
-                       keycode = KEY_BRIGHTNESSUP;
-               } else if (oldb > newb) {
-                       if (disable_brightness_adjust != 1) {
-                               if (use_alt_lcd_levels)
-                                       set_lcd_level_alt(newb);
-                               else
-                                       set_lcd_level(newb);
-                       }
-                       keycode = KEY_BRIGHTNESSDOWN;
-               }
-               break;
-       default:
+       if (event != ACPI_FUJITSU_NOTIFY_CODE1) {
                keycode = KEY_UNKNOWN;
                vdbg_printk(FUJLAPTOP_DBG_WARN,
                            "unsupported event [0x%x]\n", event);
-               break;
+               input_report_key(input, keycode, 1);
+               input_sync(input);
+               input_report_key(input, keycode, 0);
+               input_sync(input);
+               return;
+       }
+
+       keycode = 0;
+       oldb = fujitsu->brightness_level;
+       get_lcd_level();
+       newb = fujitsu->brightness_level;
+
+       vdbg_printk(FUJLAPTOP_DBG_TRACE,
+                   "brightness button event [%i -> %i (%i)]\n",
+                   oldb, newb, fujitsu->brightness_changed);
+
+       if (oldb < newb) {
+               if (disable_brightness_adjust != 1) {
+                       if (use_alt_lcd_levels)
+                               set_lcd_level_alt(newb);
+                       else
+                               set_lcd_level(newb);
+               }
+               keycode = KEY_BRIGHTNESSUP;
+       } else if (oldb > newb) {
+               if (disable_brightness_adjust != 1) {
+                       if (use_alt_lcd_levels)
+                               set_lcd_level_alt(newb);
+                       else
+                               set_lcd_level(newb);
+               }
+               keycode = KEY_BRIGHTNESSDOWN;
        }
 
        if (keycode != 0) {
-- 
2.11.0