Error messages after memory allocation failures are unnecessary and can be dropped.
This conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Drop unnecessary braces around conditional return statements - Drop error message after devm_kzalloc() failure Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- drivers/input/keyboard/adp5520-keys.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/keyboard/adp5520-keys.c b/drivers/input/keyboard/adp5520-keys.c index db1004dad108..de69d415c2b5 100644 --- a/drivers/input/keyboard/adp5520-keys.c +++ b/drivers/input/keyboard/adp5520-keys.c @@ -91,10 +91,8 @@ static int adp5520_keys_probe(struct platform_device *pdev) return -EINVAL; dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); - if (!dev) { - dev_err(&pdev->dev, "failed to alloc memory\n"); + if (!dev) return -ENOMEM; - } input = devm_input_allocate_device(&pdev->dev); if (!input) -- 2.7.4
