On Fri, Jan 20, 2017 at 8:30 PM, Johannes Thumshirn <jthumsh...@suse.de> wrote: > On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote: >> Small glitch/degraded performance in Crusader is improved with SAS >> drives by removing unnecessary spinlocks while clearing scsi command >> in drivers internal lookup table. >> >> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> >> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> >> --- > > Whats wrong with creating a __scsih_scsi_lookup_get_clear() and calling > it with the scsi_lookup_lock held from _scsih_scsi_lookup_get_clear() > instead of duplicating the code? > > It's quite common in the linux kernel to have two functions func and __func, > where func is > > func() > { > spin_lock(); > __func(); > spin_unlock(); > } >
Sure, We will resend this path with this change. Thanks, Sreekanth > -- > Johannes Thumshirn Storage > jthumsh...@suse.de +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850