On Mon, 16 Jan 2017, Javier Martinez Canillas wrote: > Hello Chanwoo, > > Thanks for the review. > > On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > > Hi, > > > > I think that this patch better to squash with patch3. > > After applying the patch3, this driver doesn't use > > the max77686_i2c_id table. > > > > I usually prefer to separate each change in a different patch, > AFAICT moving to use the .probe_new callback and removing the > I2C id table are two different changes. > > I can squash if that's the correct approach though, I will let > Lee decide.
This should really be a single patch, as the previous one leaves this code redundant, but ... meh! -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
