On 25-Jan-17 20:45, Wolfram Sang wrote: > >> + * i2c_slave_mode_detect - detect operation mode > > I'd rather name it 'i2c_detect_slave_mode'
I will do a V4 with this change. > >> + * @dev: The device owning the bus >> + * >> + * This checks the device nodes for an I2C slave by checking the address >> + * used. >> + * >> + * Returns true if an I2C slave is detected, otherwise returns false. > > Both paragraphs could be a little more explicit. It is not about > "slaves" or "clients" in general, but about those entries which make the > current master act as a slave, too. > Ok, I see your point of view. I will reword it also. > The code looks good to me, so we are close to go! > > Thanks, > > Wolfram > Great! Thanks