On Thu, Jan 26, 2017 at 11:22:49AM +0100, Ingo Molnar wrote: > The 'kbuf' parameter is unused in the _user() side of the API, remove it. > > This simplifies the code and makes it easier to think about.
... > @@ -1010,10 +1010,7 @@ int copy_xstate_to_kernel(unsigned int pos, unsigned > int count, void *kbuf, stru > } > > static inline int > -__copy_xstate_to_user(unsigned int pos, unsigned int count, > - void *kbuf, void __user *ubuf, > - const void *data, const int start_pos, > - const int end_pos) > +__copy_xstate_to_user(unsigned int pos, unsigned int count, void __user > *ubuf, const void *data, const int start_pos, const int end_pos) That and similar lines are insanely long and could be broken. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.