Hi Ksenija, > Ksenija Stanojevic <ksenija.stanoje...@gmail.com> hat am 29. Januar 2017 um > 19:04 geschrieben: > > > Add support for sixteen-channel 12-bit resolution ADC and its functions, > which include general-purpose ADC readings, battery voltage measurement, > and die temperature measurement. > > Signed-off-by: Ksenija Stanojevic <ksenija.stanoje...@gmail.com> > Reviewed-by: Jonathan Cameron <ji...@kernel.org> > Reviewed-by: Marek Vasut <ma...@denx.de> > --- > ... > diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c > new file mode 100644 > index 0000000..cc8d6af > --- /dev/null > +++ b/drivers/iio/adc/mxs-lradc-adc.c > @@ -0,0 +1,843 @@ > ... > + > +#define SHOW_SCALE_AVAILABLE_ATTR(ch) > \ > +static IIO_DEVICE_ATTR(in_voltage##ch##_scale_available, S_IRUGO, \ > + mxs_lradc_adc_show_scale_avail, NULL, ch) > +
checkpatch complains here: ERROR: Macros with complex values should be enclosed in parentheses #498: FILE: drivers/iio/adc/mxs-lradc-adc.c:343: +#define SHOW_SCALE_AVAILABLE_ATTR(ch) \ +static IIO_DEVICE_ATTR(in_voltage##ch##_scale_available, S_IRUGO, \ + mxs_lradc_adc_show_scale_avail, NULL, ch) WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #499: FILE: drivers/iio/adc/mxs-lradc-adc.c:344: +static IIO_DEVICE_ATTR(in_voltage##ch##_scale_available, S_IRUGO, \ total: 1 errors, 2 warnings, 869 lines checked But the iio values on Olinuxino Maxi looks good. Tested-by: Stefan Wahren <stefan.wah...@i2se.com>
