On 01/29/2017 06:53 PM, Jens Axboe wrote:
> On 01/29/2017 06:43 PM, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> After merging the block tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/nvme/host/scsi.c: In function 'nvme_scsi_translate':
>> drivers/nvme/host/scsi.c:2350:9: error: 'BLK_MAX_CDB' undeclared (first use
>> in this function)
>> u8 cmd[BLK_MAX_CDB];
>> ^
>> drivers/nvme/host/scsi.c:2350:9: note: each undeclared identifier is
>> reported only once for each function it appears in
>> drivers/nvme/host/scsi.c:2350:5: warning: unused variable 'cmd'
>> [-Wunused-variable]
>> u8 cmd[BLK_MAX_CDB];
>> ^
>> drivers/nvme/host/scsi.c: In function 'nvme_sg_io':
>> drivers/nvme/host/scsi.c:2454:20: error: 'BLK_MAX_CDB' undeclared (first use
>> in this function)
>> if (hdr.cmd_len > BLK_MAX_CDB)
>> ^
>>
>> Caused by commit
>>
>> 82ed4db499b8 ("block: split scsi_request out of struct request")
>>
>> I have used the block tree from next-20170125 for today.
>
> Huh, I wonder how that snuck past my allmodconfig builds, that looks
> like a clear failure.
Fixed, sorry about that.
--
Jens Axboe
