Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu: > Cc: Jiri Olsa <[email protected]> > Cc: Namhyung Kim <[email protected]> > Signed-off-by: Taeung Song <[email protected]>
The title of this patch is misleading, ambiguous. It leads one to have doubt if we were not incrementing that index before and now we are, after successfully calling perf_evsel__new_idx(). It should have been: "perf tools: Only increase index if perf_evsel__new_idx() succeeds" - Arnaldo > --- > tools/perf/util/parse-events.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 87a3e5a..ac47c12 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -311,10 +311,11 @@ __add_event(struct list_head *list, int *idx, > > event_attr_init(attr); > > - evsel = perf_evsel__new_idx(attr, (*idx)++); > + evsel = perf_evsel__new_idx(attr, *idx); > if (!evsel) > return NULL; > > + (*idx)++; > evsel->cpus = cpu_map__get(cpus); > evsel->own_cpus = cpu_map__get(cpus); > > -- > 2.7.4
