On Thu, 2017-02-02 at 17:41 -0800, Dmitry Torokhov wrote:
> There is no reason why statically defined properties should be
> modifiable,
> so let's make device_add_properties() and the rest of pset_*()
> functions to
> take const pointers to properties.
>
> This will allow us to mark properties as const/__initconst at
> definition
> sites.
>
Looks good to me.
FWIW:
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Though, nitpicks below.
> static struct property_set *pset_copy_set(const struct property_set
> *pset)
> {
> - const struct property_entry *entry;
> + struct property_entry *props;
Can we leave the name?
> - p->properties = kcalloc(n + 1, sizeof(*entry), GFP_KERNEL);
>
> + p->properties = props = kcalloc(n + 1, sizeof(*props),
> GFP_KERNEL);
> if (!p->properties) {
> kfree(p);
> return ERR_PTR(-ENOMEM);
> }
>
> for (i = 0; i < n; i++) {
> - int ret = pset_copy_entry(&p->properties[i],
> + int ret = pset_copy_entry(&props[i],
> &pset->properties[i]);
Do we need these changes?
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
