On Sun, Feb 05, 2017 at 05:12:46PM +0100, Mark Brown wrote: > On Sat, Feb 04, 2017 at 09:45:02AM -0800, Dmitry Torokhov wrote: > > On Sat, Feb 04, 2017 at 12:48:19PM +0100, Mark Brown wrote: > > > > It really shouldn't be either of these things, at least on DT systems. > > > But it definitely happens on ACPI systems for drivers for peripherals > > that we share between both x86 and ARM. > > Something that makes the warning informational only on ACPI systems > would be fine.
I can definitely select the severity based on acpi_disabled flag, but I think you should reconsider: from what I have seen in the kernel quite a few driversi, even OF-specific ones, select regulator_get_optional() for no good reason other than to avoid this "scary" warning. If its severity were reduced quite a few drivers could be switched to normal regulator_get(). Candidates for conversion (not complete, just examples): drivers/input/touchscreen/zforce_ts.c drivers/input/touchscreen/tsc200x-core.c drivers/power/avs/rockchip-io-domain.c drivers/mfd/stmpe.c ... and more... Thanks. -- Dmitry
