On Wed, Feb 08, 2017 at 10:22:32AM +0000, Lee Jones wrote: > On Tue, 31 Jan 2017, Charles Keepax wrote: > > > arizona_poll_reg essentially hard-codes regmap_read_poll_timeout, this > > patch updates the implementation to use regmap_read_poll_timeout. We > > still keep arizona_poll_reg around as regmap_read_poll_timeout is a > > macro so rather than expand this for each caller keep it wrapped in > > arizona_poll_reg. > > > > Whilst we are doing this make the timeouts a little more generous as the > > previous system had a bit more slack as it was done as a delay per > > iteration of the loop whereas regmap_read_poll_timeout compares ktime's. > > > > Signed-off-by: Charles Keepax <[email protected]> > > --- > > drivers/mfd/arizona-core.c | 37 ++++++++++++++----------------------- > > 1 file changed, 14 insertions(+), 23 deletions(-) > > Roll this up into 3/4. >
I can if you feel strongly about it but it seems much cleaner to separate the change in interface for the function and the refactoring the implementation. Thanks, Charles
