On Thu 2017-02-09 09:11:47, Viresh Kumar wrote: > The switch block handles all the QOS request types present today, but > starts giving compilation warnings as soon as a new type is added and > not handled in this. > > To prevent against that, add the default case as well and do a WARN from > it.
I'd say compilation-time warning is better than hmm.... stacktrace and memory leak at runtime? > --- a/drivers/base/power/qos.c > +++ b/drivers/base/power/qos.c > @@ -621,6 +621,9 @@ static void __dev_pm_qos_drop_user_request(struct device > *dev, > req = dev->power.qos->flags_req; > dev->power.qos->flags_req = NULL; > break; > + default: > + WARN_ON(1); > + return; > } > __dev_pm_qos_remove_request(req); > kfree(req); -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
