On Mon, Feb 06, 2017 at 07:05:29AM -0800, Andrey Smirnov wrote:
> Add code allowing for control of various power domains managed by GPCv2
> IP block found in i.MX7 series of SoCs. Power domains covered by this
> patch are:
>
> - PCIE PHY
> - MIPI PHY
> - USB HSIC PHY
> - USB OTG1/2 PHY
>
> Support for any other power domain controlled by GPC is not present, and
> can be added at some later point.
>
> Testing of this code was done against a PCIe driver.
>
> Cc: yurov...@gmail.com
> Cc: Lucas Stach <l.st...@pengutronix.de>
> Cc: Rob Herring <robh...@kernel.org>
> Cc: Mark Rutland <mark.rutl...@arm.com>
> Cc: Fabio Estevam <fabio.este...@nxp.com>
> Cc: devicet...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com>
> ---
>
> Shawn:
>
> Since this driver was modlelled after analogous driver for i.MX6 from
> Lucas Stach
>
> https://www.spinics.net/lists/arm-kernel/msg558548.html
>
> I made this patch to be applied on top of his. Please let me know if
> that was a bad idea.
>
>
> .../devicetree/bindings/power/fsl,imx-gpcv2.txt | 73 ++++
> drivers/soc/imx/Makefile | 2 +-
> drivers/soc/imx/gpcv2.c | 380
> +++++++++++++++++++++
> include/dt-bindings/power/imx7-power.h | 18 +
> 4 files changed, 472 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> create mode 100644 drivers/soc/imx/gpcv2.c
> create mode 100644 include/dt-bindings/power/imx7-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> new file mode 100644
> index 0000000..949e190
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> @@ -0,0 +1,73 @@
> +Freescale i.MX General Power Controller v2
> +==========================================
> +
> +The i.MX7S/D General Power Control (GPC) block contains Power Gating
> +Control (PGC) for various power domains.
> +
> +Required properties:
> +
> +- compatible: Should be "fsl,imx7d-gpc"
> +
> +- reg: should be register base and length as documented in the
> + datasheet
> +
> +- interrupts: Should contain GPC interrupt request 1
> +
> +- #power-domain-cells: Should be 1, see below:
Should be 1 or ...
> +
> +Power domains contained within GPC node are generic power domain
> +providers, documented in
> +Documentation/devicetree/bindings/power/power_domain.txt, which are
> +described as subnoded of the power gating controller 'pgc' node,
s/subnoded/subnodes/
> +which, in turn, is expected to conatine the following:
s/conatine/contain/
> +
> +Required properties:
> +
> +- reg: Power domain index. Valid values are defined in
> + include/dt-bindings/power/imx7-power.h
> +
> +- #power-domain-cells: Should be 0
... 0?
> +
> +Optional properties:
> +
> +- power-supply: Power supply used to power the domain
> +
> +Example:
> +
> + gpc: gpc@303a0000 {
> + compatible = "fsl,imx7d-gpc";
> + reg = <0x303a0000 0x10000>;
> + interrupt-controller;
> + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> + #interrupt-cells = <3>;
> + interrupt-parent = <&intc>;
> +
> + pgc {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pgc_pcie_phy: pgc-pcie-phy-domain {
> + #power-domain-cells = <0>;
> +
> + reg = <IMX7_POWER_DOMAIN_PCIE_PHY>;
> + power-supply = <®_1p0d>;
> + };
> + };
> + };
> +
> +
> +Specifying power domain for IP modules
> +======================================
> +
> +IP cores belonging to a power domain should contain a 'power-domains'
> +property that is a phandle for PGC node representing the domain.
> +
> +Example of a device that is part of the PCIE_PHY power domain:
> +
> + pcie: pcie@0x33800000 {
> + reg = <0x33800000 0x4000>,
> + <0x4ff00000 0x80000>;
> + /* ... */
> + power-domains = <&pgc_pcie_phy>;
> + /* ... */
> + };
