On Fri, 10 Feb 2017, John Stultz wrote: > On Fri, Feb 10, 2017 at 5:37 PM, Jess Frazelle <[email protected]> wrote: > > Marked syscore_ops structs as __ro_after_init when register_syscore_ops was > > called only during init. Most of the caller functions were already > > annotated as > > __init. > > unregister_syscore_ops() was never called on these ops. > > This protects the data structure from accidental corruption. > > > > Suggested-by: Kees Cook <[email protected]> > > Signed-off-by: Jess Frazelle <[email protected]> > > Acked-by: Rik van Riel <[email protected]> > > Thanks for sending this out. Looks reasonable to me. I'll queue it for > testing, targeting for 4.12.
NAK. See: http://lkml.kernel.org/r/alpine.DEB.2.20.1702110948030.3734@nanos Thanks, tglx

