On Sun, Feb 12, 2017 at 11:04:10PM +0100, Boris Brezillon wrote: > +Mika > > On Sun, 12 Feb 2017 22:45:43 +0100 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > On Sun, 12 Feb 2017 17:43:43 +0100 > > Nicholas Mc Guire <der.h...@hofr.at> wrote: > > > > > This fixes a sparse warning about > > > > Your commit message seems to be incomplete. > > And here too, please change the prefix to "mtd: spi-nor: intel: ". >
What Im doing for checking prefix is: hofrat@debian:~/git/linux-next$ git log --oneline drivers/mtd/spi-nor/intel-spi.c 8afda8b spi-nor: Add support for Intel SPI serial flash controller is the method of checking the commit prefix with git log --oneline inapropriate ? How would I have found the "mtd: spi-nor: intel:" in this case ? thx! ohfrat > > > > Once fixed, > > > > Acked-by: Boris Brezillon <boris.brezi...@free-electrons.com> > > > > > > > > Signed-off-by: Nicholas Mc Guire <der.h...@hofr.at> > > > --- > > > > > > sparse complained about: > > > drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return > > > expression (different address spaces) > > > drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi * > > > drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base > > > > > > Patch was compile tested with: multi_v7_defconfig (implies > > > CONFIG_MTD_SPI_NOR=y) > > > > > > Patch is against 4.10-rc6 (localversion-next is next-20170210) > > > > > > drivers/mtd/spi-nor/intel-spi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/mtd/spi-nor/intel-spi.c > > > b/drivers/mtd/spi-nor/intel-spi.c > > > index e43ce63..986a3d0 100644 > > > --- a/drivers/mtd/spi-nor/intel-spi.c > > > +++ b/drivers/mtd/spi-nor/intel-spi.c > > > @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev, > > > > > > ispi->base = devm_ioremap_resource(dev, mem); > > > if (IS_ERR(ispi->base)) > > > - return ispi->base; > > > + return ERR_CAST(ispi->base); > > > > > > ispi->dev = dev; > > > ispi->info = info; > > >
