> -----Original Message----- > From: Boris Ostrovsky [mailto:[email protected]] > Sent: 13 February 2017 14:09 > To: Paul Durrant <[email protected]>; [email protected]; > [email protected] > Cc: Juergen Gross <[email protected]> > Subject: Re: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP > > > >> How about something like (with rather arbitrary values) > >> > >> #define PRIVCMD_DMOP_MAX_NUM_BUFFERS 16 > >> #define PRIVCMD_DMOP_MAX_TOT_BUFFER_SZ 4096 > >> > >> and make them part of the interface (i.e. put them into privcmd.h)? > > > > Given that the values are arbitrary, I think it may be better to make them > module params. They can then at least be tweaked if privcmd becomes a > problem with later dm_ops. > > Making them adjustable is a good thing but we still need default values. >
Oh, sure. I think I'll actually go for 16 bufs and a max of 4k per bufs as defaults. Patch v3 (including a fix for the arm build) coming shortly. Cheers, Paul > > -boris
