On 02/14, Byungchul Park wrote:
>
> Although llist provides proper APIs, they are not used. Make them used.
Reviewed-by: Oleg Nesterov <o...@redhat.com>
> Signed-off-by: Byungchul Park <byungchul.p...@lge.com>
> ---
> fs/file_table.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 6d982b5..3209da2 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -231,12 +231,10 @@ static void __fput(struct file *file)
> static void delayed_fput(struct work_struct *unused)
> {
> struct llist_node *node = llist_del_all(&delayed_fput_list);
> - struct llist_node *next;
> + struct file *f, *t;
>
> - for (; node; node = next) {
> - next = llist_next(node);
> - __fput(llist_entry(node, struct file, f_u.fu_llist));
> - }
> + llist_for_each_entry_safe(f, t, node, f_u.fu_llist)
> + __fput(f);
> }
>
> static void ____fput(struct callback_head *work)
> @@ -310,7 +308,7 @@ void put_filp(struct file *file)
> }
>
> void __init files_init(void)
> -{
> +{
> filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0,
> SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
> percpu_counter_init(&nr_files, 0, GFP_KERNEL);
> @@ -329,4 +327,4 @@ void __init files_maxfiles_init(void)
> n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10;
>
> files_stat.max_files = max_t(unsigned long, n, NR_FILE);
> -}
> +}
> --
> 1.9.1
>
