Re: [usb-storage] usb: storage: suspicious code

[Gustavo A. R. Silva]

Hi Oliver,

Quoting Oliver Neukum <oneu...@suse.com>:

Am Dienstag, den 14.02.2017, 23:06 -0600 schrieb Gustavo A. R. Silva:

Hi,

waitcount = 0;
do {
        result = jumpshot_get_status(us);
        if (result != USB_STOR_TRANSPORT_GOOD) {
                // I have not experimented to find the smallest
value.
                //
                msleep(50);
        }
        } while ((result != USB_STOR_TRANSPORT_GOOD) && (waitcount <
10));

        if (result != USB_STOR_TRANSPORT_GOOD)
                usb_stor_dbg(us, "Gah!  Waitcount = 10.  Bad
write!?\n");

Variable 'waitcount' is never updated inside the do-while loop. So,
either it isn't needed at all or line 316 should be modified
(++waitcount < 10)

you are correct. Waitcount needs to be incremented.

Thanks for clarifying, I'll send a patch shortly.

--
Gustavo A. R. Silva