Em Wed, Feb 15, 2017 at 03:56:30PM +0100, Marcin Nowakowski escreveu:
> Makefile in lib/api unconditionally sets the LD to support
> cross-compilation. However, when invoked from within the perf build LD
> may be already appropriately set for a given platform and the override
> may lead to cross-compilation without appropriate linker flags.
> Change the unconditional override to a conditional one.
>
> Fixes: 37b4e2020a5f ('perf build: Add EXTRA_LDFLAGS option to makefile')
> Fixes: 703e01652d25 ('tools lib api: Respect CROSS_COMPILE for the linker')
>
> Signed-off-by: Marcin Nowakowski <[email protected]>
> ---
> tools/lib/api/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
> index adba83b..42e00c4 100644
> --- a/tools/lib/api/Makefile
> +++ b/tools/lib/api/Makefile
> @@ -10,7 +10,7 @@ endif
>
> CC = $(CROSS_COMPILE)gcc
> AR = $(CROSS_COMPILE)ar
> -LD = $(CROSS_COMPILE)ld
> +LD ?= $(CROSS_COMPILE)ld
Looks strange to do this just for LD, what about CC and AR?
- Arnaldo
> MAKEFLAGS += --no-print-directory
>
> --
> 2.7.4
