Hi Jerome, On Wed, 2017-02-15 at 17:43 +0100, Jerome Brunet wrote: [...] > > > @@ -241,7 +239,7 @@ static int phy_meson8b_usb2_probe(struct > > > platform_device *pdev) > > > return PTR_ERR(priv->clk_usb); > > > > > > priv->reset = devm_reset_control_get_optional_shared(&pdev- > > > >dev, NULL); > > > - if (PTR_ERR(priv->reset) == -EPROBE_DEFER) > > > + if (PTR_ERR(priv->reset)) > > This is wrong and will always exit on error. It should be "IS_ERR". > Clearly the bug was there before your patch, but since you are changing > the faulty line, would you mind using IS_ERR instead ? > > With this changed: > Tested-by: Jerome Brunet <jbru...@baylibre.com>
Thanks for catching this, I should have changed this to IS_ERR when removing the error value comparison. regards Philipp
