> -----Original Message----- > From: Steven Rostedt [mailto:[email protected]] > Sent: Thursday, February 16, 2017 11:46 AM > To: Byungchul Park > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in > push_rt_task() > > On Thu, 16 Feb 2017 11:34:17 +0900 > Byungchul Park <[email protected]> wrote: > > > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when > > it returns a task other than NULL, which means that task_cpu(task) must > > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be > > rq->cpu as well. Remove the redundant condition and make code simpler. > > > > By this patch, unnecessary one branch and two LOAD operations in 'if' > > statement can be avoided. > > > > Signed-off-by: Byungchul Park <[email protected]> > > Reviewed-by: Steven Rostedt (VMware) <[email protected]> > > Reviewed-by: Juri Lelli <[email protected]> > > --- > > This is a different patch, I don't believe Juri reviewed it yet.
Hello juri, I should have asked you first and been more careful before I added 'reviewed-by'. Can I ask you for your opinion about the additional one?
