----- Original Message -----
> From: "Colin King" <[email protected]>
> To: "Selvin Xavier" <[email protected]>, "Devesh Sharma" 
> <[email protected]>, "Somnath Kotur"
> <[email protected]>, "Sriharsha Basavapatna" 
> <[email protected]>, "Doug Ledford"
> <[email protected]>, "Sean Hefty" <[email protected]>, "Hal Rosenstock" 
> <[email protected]>,
> [email protected]
> Cc: [email protected], [email protected]
> Sent: Friday, February 17, 2017 10:35:22 AM
> Subject: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero
> 
> From: Colin Ian King <[email protected]>
> 
> rc is initialized to zero but is then updated by calls to
> bnxt_qplib_free_fast_reg_page_list and/or bnxt_qpliob_free_mrw
> so the initialization is redundant and can be removed.
> 
> Detected with CoverityScan, CID#1408448 ("Unused Value")
> 
> Signed-off-by: Colin Ian King <[email protected]>
> ---
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index 33af2e3..17aa087 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -2818,7 +2818,7 @@ int bnxt_re_dereg_mr(struct ib_mr *ib_mr)
>  {
>       struct bnxt_re_mr *mr = container_of(ib_mr, struct bnxt_re_mr, ib_mr);
>       struct bnxt_re_dev *rdev = mr->rdev;
> -     int rc = 0;
> +     int rc;
>  
>       if (mr->npages && mr->pages) {
>               rc = bnxt_qplib_free_fast_reg_page_list(&rdev->qplib_res,
> --
> 2.10.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Makes sense, looks fine.
Reviewed-by: Laurence Oberman <[email protected]>

Reply via email to